linux-kernel - [PATCH] tokenring/3c359.c: Prevent possible mem leak when open failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081123214410.44810f99@jirka.pirko.cz>
Date:	Sun, 23 Nov 2008 21:44:10 +0100
From:	Jirka Pirko <jirka@...ko.cz>
To:	linux-kernel@...r.kernel.org
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org, davem@...emloft.net
Subject: [PATCH] tokenring/3c359.c: Prevent possible mem leak when open
 failed

Freeing previously allocated buffers in case of error.

Signed-off-by: Jirka Pirko <jirka@...ko.cz>
---
 drivers/net/tokenring/3c359.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index 46fb308..4bb9ca8 100644
--- a/drivers/net/tokenring/3c359.c
+++ b/drivers/net/tokenring/3c359.c
@@ -669,6 +669,8 @@ static int xl_open(struct net_device *dev)
 	if (i==0) { 
 		printk(KERN_WARNING "%s: Not enough memory to allocate rx buffers. Adapter disabled \n",dev->name) ; 
 		free_irq(dev->irq,dev) ; 
+		kfree(xl_priv->xl_tx_ring);
+		kfree(xl_priv->xl_rx_ring);
 		return -EIO ; 
 	} 
 
-- 
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/