linux-kernel - Re: poll: allow f_op->poll to sleep, take #3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081123033457.GA1912@cynthia.pants.nu>
Date:	Sat, 22 Nov 2008 19:34:57 -0800
From:	Brad Boyer <flar@...andria.com>
To:	Tejun Heo <htejun@...il.com>
Cc:	Davide Libenzi <davidel@...ilserver.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Matthew Wilcox <matthew@....cx>,
	Miklos Szeredi <miklos@...redi.hu>, arjan@...ux.intel.com,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	hch@...radead.org, Ingo Molnar <mingo@...e.hu>,
	rminnich@...dia.gov, ericvh@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: poll: allow f_op->poll to sleep, take #3

On Sun, Nov 23, 2008 at 12:05:53PM +0900, Tejun Heo wrote:
> I thought try_to_wake_up() was made static to avoid abuse but then again
> creating dummy waitqueue is an obvious abuse of waitqueue.  What do
> other people think?  I'll be happy to use try_to_wake_up() directly.

Do you need all the extra arguments? The function wake_up_process()
is already a wrapper around try_to_wake_up() and is exported, but
it doesn't have any arguments other than the task_struct and uses
defaults for the other arguments. I'm not sure if anything in your
code would break by ignoring the other possible values instead of
passing them along from the arguments into the caller.

	Brad Boyer
	flar@...andria.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/