linux-kernel - Re: Regression: ACPI AC driver doesn't work on Toshiba Portege R500 (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200811240037.15835.rjw@sisk.pl>
Date:	Mon, 24 Nov 2008 00:37:15 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Cc:	Alexey Starikovskiy <astarikovskiy@...e.de>,
	Len Brown <lenb@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Zhang Rui <rui.zhang@...el.com>, walken <walken@....org>
Subject: Re: Regression: ACPI AC driver doesn't work on Toshiba Portege R500 (bisected)

On Sunday, 23 of November 2008, Rafael J. Wysocki wrote:
> Hi,
> 
> With current mainline (2.6.28-rc6-git1 as of today) on Toshiba Portege R500 the
> status of the AC adapter is not updated when the adapter is unplugged and
> plugged in.  Evidently, /sys/class/power_supply/ADP1/online always contains the
> same value.  Interestingly enough, though, if the box is suspended to RAM and
> resumed, the status of the AC adapter is correctly updated, but the value read
> at that time remains in /sys/class/power_supply/ADP1/online until the next
> suspend/resume cycle regardless of what's going on with the AC adapter.
> 
> 2.6.27.7 works correctly on this box so the recent EC patches don't seem to
> cause this regression to happen.
> 
> Any other ideas?

The problem was introduced by the following commit:

commit faee816b1502385dc9bc5abf2960d1cc645844d1
Author: Zhang Rui <rui.zhang@...el.com>
Date:   Fri Sep 12 11:12:25 2008 +0800

    ACPI: don't enable control method power button as wakeup device when Fixed Power button is used

    don't enable control method power button as wakeup device
    when Fixed Power button is used.

    http://bugzilla.kernel.org/show_bug.cgi?id=10503

    Tested-by: walken@....org <walken@....org>
    Signed-off-by: Zhang Rui <rui.zhang@...el.com>
    Signed-off-by: Len Brown <len.brown@...el.com>

Reverting this commit on top of the current mainline makes the kernel behave
correctly again.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/