linux-kernel - RE: [PATCH] IA64: fix VT-d dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A6AD88C3F2289247BE726C37303E1EB88EAB5850@orsmsx505.amr.corp.intel.com>
Date:	Sat, 22 Nov 2008 22:10:05 -0800
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	'FUJITA Tomonori' <fujita.tomonori@....ntt.co.jp>
CC:	"Luck, Tony" <tony.luck@...el.com>,
	"'dwmw2@...radead.org'" <dwmw2@...radead.org>,
	"'linux-ia64@...r.kernel.org'" <linux-ia64@...r.kernel.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'mingo@...e.hu'" <mingo@...e.hu>
Subject: RE: [PATCH] IA64: fix VT-d dma_mapping_error

>Hmm, intel_dma_mapping_error is used to test only the value that
>intel_map_single() returns. If intel_map_single() returns a non-zero
>dma address, it belongs to hwdev's domain. So intel_dma_mapping_error
>can simply return 1 (failure) if the dma_addr is zero.

Then there is no usage of hwdev which is one of two parameters in intel_dma_mapping_error?

Maybe checking dma_addr only is good enough for the function? At least it's fast to check errors.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/