linux-kernel - Re: [PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2008 10:35:53 +0000
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Alexander van Heukelum" <heukelum@...lshack.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>, "Andi Kleen" <andi@...stfloor.org>,
	"Cyrill Gorcunov" <gorcunov@...il.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Glauber Costa" <gcosta@...hat.com>,
	"Matt Mackall" <mpm@...enic.com>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"Nick Piggin" <nickpiggin@...oo.com.au>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE_END

>Right. I thought of END and ENDPROC as equivalent, so I added the change
>to this patch as a small cleanup only. But if we want this .type
>annotation, what about KPROBE_END? should it include one there too?

Yes, it always bothered me that there's no KPROBE_ENDPROC() (or
alternatively, as this being code is implied by the macro, it didn't do the
annotation by default).

>I'm getting a feeling we would be better off removing KPROBE_ENTRY and
>KPROBE_END if favour of explicitly changing sections in the .S files?
>And using the ENDPROC annotation for all procedures?

It got explicitly added a while back, so there must have been a reason to
*not* do the section adjustments explicitly. And given the current discussion
I'd also assume that more hiding of code in macros is the preferred route.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/