linux-kernel - Re: [PATCH] crypto: ansi_cprng: fix inverted DT increment routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081124132043.GA18313@gondor.apana.org.au>
Date:	Mon, 24 Nov 2008 21:20:43 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Neil Horman <nhorman@...driver.com>
Cc:	Jarod Wilson <jarod@...hat.com>, linux-crypto@...r.kernel.org,
	davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ansi_cprng: fix inverted DT increment routine

On Thu, Nov 13, 2008 at 01:44:31PM -0500, Neil Horman wrote:
> On Thu, Nov 13, 2008 at 11:36:11AM -0500, Jarod Wilson wrote:
> > The ANSI X9.31 PRNG docs aren't particularly clear on how to increment DT,
> > but empirical testing shows we're incrementing from the wrong end. A 10,000
> > iteration Monte Carlo RNG test currently winds up not getting the expected
> > result.
> > 
> > From http://csrc.nist.gov/groups/STM/cavp/documents/rng/RNGVS.pdf :
> > 
> > # CAVS 4.3
> > # ANSI931 MCT
> > [X9.31]
> > [AES 128-Key]
> > 
> > COUNT = 0
> > Key = 9f5b51200bf334b5d82be8c37255c848
> > DT = 6376bbe52902ba3b67c925fa701f11ac
> > V = 572c8e76872647977e74fbddc49501d1
> > R = 48e9bd0d06ee18fbe45790d5c3fc9b73
> > 
> > Currently, we get 0dd08496c4f7178bfa70a2161a79459a after 10000 loops.
> > 
> > Inverting the DT increment routine results in us obtaining the expected result
> > of 48e9bd0d06ee18fbe45790d5c3fc9b73. Verified on both x86_64 and ppc64.
> > 
> > Signed-off-by: Jarod Wilson <jarod@...hat.com>

Patch applied.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/