lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hej11jlys.wl%tiwai@suse.de>
Date:	Mon, 24 Nov 2008 14:24:27 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Richard A. Holden III" <aciddeath@...il.com>
Cc:	linux-next@...r.kernel.org, alsa-devel@...a-project.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [alsa-devel] [PATCH] Remove unused variable from tlv320aic23 codec

At Thu, 20 Nov 2008 11:03:23 -0700,
Richard A. Holden III wrote:
> 
> Remove codec var from tlv320aic23_set_dai_sysclk, it is assigned to
> but never read.
> 
> Signed-off-by: Richard A. Holden III <aciddeath@...il.com>
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Liam Girdwood <lrg@...mlogic.co.uk>
> Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> Cc: alsa-devel@...a-project.org
> ---
>  sound/soc/codecs/tlv320aic23.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

This is already fixed in the upstream, but pretty differently.


Takashi

> diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
> index 44308da..45395d0 100644
> --- a/sound/soc/codecs/tlv320aic23.c
> +++ b/sound/soc/codecs/tlv320aic23.c
> @@ -421,8 +421,6 @@ static int tlv320aic23_set_dai_fmt(struct snd_soc_dai *codec_dai,
>  static int tlv320aic23_set_dai_sysclk(struct snd_soc_dai *codec_dai,
>  				      int clk_id, unsigned int freq, int dir)
>  {
> -	struct snd_soc_codec *codec = codec_dai->codec;
> -
>  	switch (freq) {
>  	case 12000000:
>  		return 0;
> -- 
> 1.5.6.4
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ