linux-kernel - Re: [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature based model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081124133116.GA31269@rakim.wolfsonmicro.main>
Date:	Mon, 24 Nov 2008 13:31:16 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Samuel Ortiz <sameo@...nedhand.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature
	based model

On Mon, Nov 24, 2008 at 11:37:55AM +0100, Samuel Ortiz wrote:

> Dont you prefer to use the WM8350_REV_* values in your code rather than some
> undocumented constants like that ?
> I understand that reading the code below will make those constants obvious,
> but still...

I don't find them enormously helpful, TBH - the constant gets used in
exactly one place and there's been a bit of skew between what some of
the ID registers are called and thier actual meaning which doesn't help.

I'll repost with the #defines for the revisons added back, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/