linux-kernel - Re: [PATCH 1/2] md: make devices disappear when they are no longer needed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081124144823.GC28946@ZenIV.linux.org.uk>
Date:	Mon, 24 Nov 2008 14:48:23 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Tejun Heo <teheo@...e.de>
Cc:	Neil Brown <neilb@...e.de>, linux-kernel@...r.kernel.org,
	linux-raid@...r.kernel.org, Doug Ledford <dledford@...hat.com>,
	Greg KH <greg@...ah.com>, Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [PATCH 1/2] md: make devices disappear when they are no longer
	needed.

On Mon, Nov 24, 2008 at 11:26:20PM +0900, Tejun Heo wrote:
> Tejun Heo wrote:
> > Can we then make gendisk hold owner module till it gets released?  It
> > would be much nicer to write code to if we can keep the regular object
> > reference counting across module boundaries and being able to taking
> > down a module while devices are active isn't a too important
> > requirement.  For vast majoerity (ide, scsi, md) one way or the other
> > doesn't even matter at all.
> 
> If always holding reference is too much of a change, we can do
> 
> 	if (gendisk->fops->disk_release) {
> 		__module_get(gendisk->fops->owner);
> 		gendisk->fops->disk_release(gendisk);
> 		module_put(gendisk->fops->owner);
> 	}

With ->fops in already freed memory?  Good idea, that...

Look, that's the wrong object *and* the wrong place; gendisk is separate
from driver-specific data structures for a good reason.

_IF_ you want to tie something to "opened or in process of being opened",
the right place is __blkdev_get()/blkdev_put() (BTW, note that get_gendisk()
is essentially a part of __blkdev_get()).

It's not about rmmod of module while some disk is opened; _that_ is impossible
as is.  It's about e.g. modules like sd.ko that would be flat-out impossible
to unload at all.

Think for a minute: we do have a bunch of gendisks created by sd; they stay
around until we rmmod the damn thing and we really want it that way.
We can't have their existence pinning sd down.  What we do is "module is
busy if any of those is opened or in the middle of opening".

The same goes for just about any block driver out there; md is weird for
one reason - it wants to have devices possible to open without any prior
event that would mark the beginning of availability (such as e.g. hardware
detection for SCSI, IDE, etc.).  That is a side effect of bad API - there
*is* a moment for md that would be a good candidate for such event (array
being completely configured and available for normal IO), but that would
require an API for creating and configuring these suckers that wouldn't
start with "First you open the very device you are trying to create..."
Too bad - we are tied to lousy userland interface and can't get rid of
it.  That is where all the PITA is coming from.

And the right way to deal with that is to have explicit boundaries for
"opened or in process of being opened"; we almost have them (probe and
final release), so the only point we are missing is on failure exit from
__blkdev_get()...

I really think that it's much saner than trying to change the lifetime
rules for gendisk, etc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/