linux-kernel - Re: [PATCH 4/4] tracing/function-return-tracer: Support for dynamic ftrace on function return tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0811241707240.907@gandalf.stny.rr.com>
Date:	Mon, 24 Nov 2008 17:08:21 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] tracing/function-return-tracer: Support for dynamic
 ftrace on function return tracer


On Sun, 16 Nov 2008, Frederic Weisbecker wrote:
>  
>  static void ftrace_replace_code(int enable)
> @@ -1405,10 +1417,17 @@ int register_ftrace_function(struct ftrace_ops *ops)
>  		return -1;
>  
>  	mutex_lock(&ftrace_sysctl_lock);
> +
> +	if (ftrace_tracing_type == FTRACE_TYPE_RETURN) {
> +		ret = -EBUSY;
> +		goto out;
> +	}
> +

Why do we need to disable all new tracing functions when we do return 
tracing??

-- Steve

>  	ret = __register_ftrace_function(ops);
>  	ftrace_startup();
> -	mutex_unlock(&ftrace_sysctl_lock);
>  
> +out:
> +	mutex_unlock(&ftrace_sysctl_lock);
>  	return ret;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/