linux-kernel - Re: w35und: fix Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1227518703.3718.60.camel@penberg-laptop>
Date:	Mon, 24 Nov 2008 11:25:02 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Pavel Machek <pavel@...e.cz>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: w35und: fix Kconfig

On Mon, 2008-11-24 at 10:18 +0100, Pavel Machek wrote:
> 4KSTACK dependency was needed when driver carried its own softmac
> layer. That layer is gone, and functions have reasonably small stack
> footprint -> dependency can be removed.
> 
> Add better description of hardware this driver is targetted at.
> 
> Signed-off-by: Pavel Machek <pavel@...e.cz>

While I don't have the hardware to test this, I haven't seen anything in
the driver code either that abuses the kernel stack too badly.

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> 
> --- gregkh-ofic/drivers/staging/winbond/Kconfig	2008-11-19 11:39:38.000000000 +0100
> +++ gregkh/drivers/staging/winbond/Kconfig	2008-11-19 12:26:57.000000000 +0100
> @@ -1,7 +1,11 @@
>  config W35UND
> -	tristate "Winbond driver"
> -	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS
> +	tristate "IS89C35 WLAN USB driver"
> +	depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL
>  	default n
>  	---help---
> -	  This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> -	  Check http://code.google.com/p/winbondport/ for new version
> +	  This is highly experimental driver for Winbond WIFI card.
> +
> +	  HW is present in some Kohjinsha subnotebooks, and in some 
> +	  stand-alone USB modules. Chipset name seems to be w89c35d.
> +
> +	  Check http://code.google.com/p/winbondport/ for new version.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/