linux-kernel - Re: [PATCH 3/3] x86: signal: cosmetic unification of sys_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <492B3EEF.8070404@ct.jp.nec.com>
Date:	Mon, 24 Nov 2008 15:55:27 -0800
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] x86: signal: cosmetic unification of	sys_rt_sigreturn()

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:
> 
>> H. Peter Anvin wrote:
>>> Hiroshi Shimamoto wrote:
>>>>  
>>>> +#ifdef CONFIG_X86_32
>>>>  asmlinkage int sys_rt_sigreturn(unsigned long __unused)
>>>>  {
>>>>  	struct pt_regs *regs = (struct pt_regs *)&__unused;
>>>>  
>>>>  	return do_rt_sigreturn(regs);
>>>>  }
>>> Why not:
>>>
>>> asmlinkage int sys_rt_sigreturn(struct pt_regs regs)
>>> {
>>> 	return do_rt_sigreturn(&regs);
>>> }
>>>
>>> ...?
>> Good question. I didn't realize about that.
>> Will take a look.
> 
> I've applied your 3 patches to tip/x86/signal - please send a patch on 
> top of your current lineup, for the detail Peter pointed out.

OK, will do.
I think it's better to send a patch after unifying signal_{32|64}.c.

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/