linux-kernel - Re: [PATCH] ncurses based config V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b2db90b0811250004k5494cff7sfb22a91e0f6f6ab@mail.gmail.com>
Date:	Tue, 25 Nov 2008 10:04:17 +0200
From:	"Nir Tzachar" <nir.tzachar@...il.com>
To:	"Roman Zippel" <zippel@...ux-m68k.org>
Cc:	"Sam Ravnborg" <sam@...nborg.org>, "Willy Tarreau" <w@....eu>,
	linux-kernel@...r.kernel.org, bzolnier@...il.com,
	linux-kbuild@...r.kernel.org, ariveira@...il.com,
	rdunlap@...otime.net, kosaki.motohiro@...fujitsu.com,
	7eggert@....de
Subject: Re: [PATCH] ncurses based config V2

Hello.

On Tue, Nov 25, 2008 at 4:33 AM, Roman Zippel <zippel@...ux-m68k.org> wrote:
> Hi,
>
> On Mon, 24 Nov 2008, Sam Ravnborg wrote:
>
>> >   - colors are too dark.
>> Seconded. Please try to find a lighter set of default colors.
>> You may be inspired by one of the menuconfig color-sets.
>>
>> I agree that we could use a lift here - so please do not go for the
>> default color set of menuconfig.
>
> Well, the current colors seems to usable on wide variety of terminals, but
> I'm not colorblind, so I can't really complain. :)
> Before we keep discussing the colors, I'd rather suggest to drop them
> completely and maybe use colors for what actually needs attention.

The idea is using colors to give it a more modern look. Dropping
colors will bring us back to the "dark ages"...

>> >   - I'm not convinced that the parenthesis around hotkeys make the menu
>> >     that much readable, especially when there are lots of short words or
>> >     even acronyms. Eg :
>> >         [ ]   (U)TS namespace
>> >         [ ]   (I)PC namespace
>> >         [ ]   (U)ser namespace (EXPERIMENTAL)
>> >         [ ]   (P)ID Namespaces (EXPERIMENTAL)
>>
>> This looks like some ancient stuff and it must be a better way to
>> show the short-cuts.
>
> The parenthesis make it really annoying to read...

I agree. See my earlier response to Sam.

>> I would really appreciate if you could look into the above issues.
>> If you do a repost with this fixed I will try to do a proper review,
>> including code-review next time.
>
> The code is rather large, so it might be better to split the code into two
> sources, one for kconfig logic and the other for the interface logic, so
> it becomes easier to read and maintain.

Ok.

Thanks for your interest.
Cheers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/