linux-kernel - Re: [2.6.28-rc6] oprofile: "opcontrol --start" output two warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ljv8ce2j.fsf@basil.nowhere.org>
Date:	Tue, 25 Nov 2008 11:09:08 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Robert Richter <robert.richter@....com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [2.6.28-rc6] oprofile: "opcontrol --start" output two warnings

KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> writes:
>
> Index: b/arch/x86/oprofile/op_model_p4.c
> ===================================================================
> --- a/arch/x86/oprofile/op_model_p4.c	2008-11-24 06:20:04.000000000 +0900
> +++ b/arch/x86/oprofile/op_model_p4.c	2008-11-24 06:29:09.000000000 +0900
> @@ -399,6 +399,8 @@ static void p4_fill_in_addresses(struct 
>  	unsigned int i;
>  	unsigned int addr, cccraddr, stag;
>  
> +	get_cpu();

The whole thing seems broken anyways because the only caller of
fill_in_addresses only assigns to CPU 0 and fill_in_addresses only
runs on some CPU. So I guess the stagger handling could be just
removed because it's useless.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/