linux-kernel - Re: [PATCH] 8250: Eliminate compile warning of 8250.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081125104334.351e94ee@lxorguk.ukuu.org.uk>
Date:	Tue, 25 Nov 2008 10:43:34 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sheng Yang <sheng@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] 8250: Eliminate compile warning of 8250.c

> Can't understand initializing got "risk hiding future ones". As I know, didn't 

Because if you set it to NULL and later delete a line which does the
intended assignment you will no longer get a warning.

> think BUG_ON(n==null) cover this. And I don't think leave it to compiler is 
> more proper here.

The BUG_ON covers it, the current gcc gets this right and works it out.

NAK again

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/