linux-kernel - Re: [PATCH] 8250: Eliminate compile warning of 8250.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081125111342.5383c957@lxorguk.ukuu.org.uk>
Date:	Tue, 25 Nov 2008 11:13:42 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sheng Yang <sheng@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] 8250: Eliminate compile warning of 8250.c

> The logic here is strange...

Why

> If you used old compiler, you would get a warning, and you thought that's 
> ensured we won't delete a intended assignment by mistake.

No.. if you hid the warning by hacking around the compiler mistake with
extra bogus assignments you would hide a future mistake.
> 
> If you used new compiler, you wouldn't get a warning, and you think this time 
> the compiler get it right.

The compiler does now get it right - I checked.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/