[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <492BE534.5060903@compulab.co.il>
Date: Tue, 25 Nov 2008 13:44:52 +0200
From: Mike Rapoport <mike@...pulab.co.il>
To: Liam Girdwood <lrg@...mlogic.co.uk>
CC: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: move set_machine_constraints after regulator
device initialization
Liam Girdwood wrote:
> On Mon, 2008-11-24 at 18:44 +0200, Mike Rapoport wrote:
>> Calling set_machine_constraints before regulator device initialization
>> causes crash when constraints have apply_uV set.
>>
>> Signed-off-by: Mike Rapoport <mike@...pulab.co.il>
>> ---
>
> There have been recent changes to regulator registration in the
> regulator for-next branch. Does this crash still occur with for-next.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6.git #for-next
I haven't tested it yet, but looking at the code it seems the crash will occur
there as well.
regulator_register() calls set_machine_constraints() before setting rdev->dev
fields. The set_machine_constraints() in turn calls rdev->ops->set_voltage()
with NULL rdev->dev.
> Liam
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists