linux-kernel - Re: [PATCH] ncurses based config V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2008 14:35:36 +0200
From:	"Nir Tzachar" <nir.tzachar@...il.com>
To:	"Sam Ravnborg" <sam@...nborg.org>
Cc:	"Willy Tarreau" <w@....eu>,
	"Nir Tzachar" <tzachar@...d120a.cs.bgu.ac.il>,
	linux-kernel@...r.kernel.org, bzolnier@...il.com,
	zippel@...ux-m68k.org, linux-kbuild@...r.kernel.org,
	ariveira@...il.com, rdunlap@...otime.net,
	kosaki.motohiro@...fujitsu.com, 7eggert@....de
Subject: Re: [PATCH] ncurses based config V2

Hi.

On Tue, Nov 25, 2008 at 10:11 AM, Sam Ravnborg <sam@...nborg.org> wrote:
> Hi Nir.
>
>> >>         [ ]   (U)TS namespace
>> >>         [ ]   (I)PC namespace
>> >>         [ ]   (U)ser namespace (EXPERIMENTAL)
>> >>         [ ]   (P)ID Namespaces (EXPERIMENTAL)
>> >
>> > This looks like some ancient stuff and it must be a better way to
>> > show the short-cuts.
>>
>> This was the best I could come up with, as ncurses does not let you
>> use color attributed for menu items. I'll try a different scheme,
>> where the first capitalized letter is the shortcut. What do u say?
>
> Better than the above - let me see it in action and I will judge.
> I had preferred something with a colored highlight - but if ncurses
> do not support that then I think first catital letter i ok.
>
> Alternative is to use first letter in the prompt and accept the
> ambiguity.
>

There is too much ambiguity here -- what if the first letter is 'm'?
or 'n'? you have problems then.

>> > I would really appreciate if you could look into the above issues.
>> > If you do a repost with this fixed I will try to do a proper review,
>> > including code-review next time.
>>
>> Sure. I'll have a patch ready in a few days.
>
> Great - loks forward to see it.
>
>        Sam
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/