linux-kernel - Re: [patch 5/9] x86, bts: base in-kernel ds interface on handles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081125163624.GD22504@elte.hu>
Date:	Tue, 25 Nov 2008 17:36:24 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Markus Metzger <markus.t.metzger@...el.com>
Cc:	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	markus.t.metzger@...il.com, roland@...hat.com,
	akpm@...ux-foundation.org, mtk.manpages@...il.com,
	eranian@...glemail.com, juan.villacis@...el.com
Subject: Re: [patch 5/9] x86, bts: base in-kernel ds interface on handles


* Markus Metzger <markus.t.metzger@...el.com> wrote:

> +static void ds_release(struct ds_tracer *tracer, enum ds_qualifier qual)
> +{
> +	if (tracer->context) {
> +		BUG_ON(tracer->context->owner[qual] != tracer);

please use WARN_ON_ONCE() instead of crashing the box. (this is true 
in a number of other places as well in ds.c)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/