linux-kernel - Re: [PATCH] memcg reclaim shouldn't change zone->recent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081125155422.6ab07caf.akpm@linux-foundation.org>
Date:	Tue, 25 Nov 2008 15:54:22 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	riel@...hat.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kosaki.motohiro@...fujitsu.com
Subject: Re: [PATCH] memcg reclaim shouldn't change zone->recent_rotated
 statics.

On Tue, 25 Nov 2008 12:22:53 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> +	if (scan_global_lru(sc))

mutter.  scan_global_lru() is a terrible function name.  Anyone reading
that code would expect that this function, umm, scans the global LRU.

gcc has a nice convention wherein such functions have a name ending in
"_p" (for "predicate").  Don't do this :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/