linux-kernel - Re: [PATCH 2/3] ftrace: use code patching for ftrace return tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0811251922030.26424@gandalf.stny.rr.com>
Date:	Tue, 25 Nov 2008 19:23:17 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	linux-kernel@...r.kernel.org
cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 2/3] ftrace: use code patching for ftrace return tracer


On Tue, 25 Nov 2008, Steven Rostedt wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
>  int __init ftrace_dyn_arch_init(void *data)
>  {
>  	extern const unsigned char ftrace_test_p6nop[];
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index 7854d87..73147eb 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -117,6 +117,11 @@ extern void ftrace_call(void);
>  extern void mcount_call(void);
>  #ifdef CONFIG_FUNCTION_RET_TRACER
>  extern void ftrace_return_caller(void);
> +extern int ftrace_enable_ftrace_return_caller(void);
> +extern int ftrace_disable_ftrace_return_caller(void);
> +#else
> +static inline int ftrace_enable_ftrace_return_caller(void) { }
> +static inline int ftrace_disable_ftrace_return_caller(void) { }
>  #endif
>  

This is what I get for not testing the off case :-p

The above should be:

+static inline int ftrace_enable_ftrace_return_caller(void) { return 0; }
+static inline int ftrace_disable_ftrace_return_caller(void) { return 0; }

I'll fix and push again.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/