linux-kernel - Re: [PATCH 5/5 UPDATED] CUSE: implement CUSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2008 11:02:04 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	tj@...nel.org
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	fuse-devel@...ts.sourceforge.net, miklos@...redi.hu, greg@...ah.com
Subject: Re: [PATCH 5/5 UPDATED] CUSE: implement CUSE - Character device in Userspace

Hi Tejun,

Apologies for the late review.

On Sat, 22 Nov 2008, Tejun Heo wrote:
> + * cuse_conn	: contains fuse_conn and serves as bonding structure
> + * channel	: file handle connected to the userland CUSE server
> + * cdev		: the implemented character device
> + * mnt		: vfsmount which serves dentry and inode for cdev

Hmm, this mount thing seems rather pointless to me.  I understand the
motivation: to let the unmodified fuse functions use
get_fuse_conn(inode) and get_node_id(inode).  But I think we should
really bite the bullet and reimplement these functions so that they
take fuse_conn and node_id as arguments instead of the inode (and
separate out those parts which do really need the inode for the
memory mappings).

It's a bit more work on the fuse side, but overall it results in a
much cleaner architecture, don't you think?

> +	worker = kthread_run(cuse_init_worker, cuse_conn_get(cc),
> +			     "cuse-init-pid%d", current->pid);

This could be done without a kthread, by setting the ->end() callback
for the INIT request, no?

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/