[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081126143928.GA16576@tsunami.ccur.com>
Date: Wed, 26 Nov 2008 09:39:28 -0500
From: Joe Korty <joe.korty@...r.com>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add per-cpu indexing to /proc/timer_list
On Wed, Nov 26, 2008 at 07:50:04AM +0300, Alexey Dobriyan wrote:
> On Tue, Nov 25, 2008 at 06:14:45PM -0500, Joe Korty wrote:
> > Per-cpu indexing of /proc/timer_list.
> >
> > /proc/timer_list, potentially a very large file, is in
> > danger of overflowing its seq_file buffer. So 'split up'
> > the buffering on cpu ID boundaries. This should make this
> > file more likely to be useful on largish SMP systems.
>
> What do you mean?
>
> You can't overflow seq_file buffer unless kmalloc() will fail large
> allocation. And changing internals doesn't change amount of stuff
> to be shown, which is the only thing which can lead to large buffer
> need.
You're right, I missed the re-malloc part.
Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists