linux-kernel - Re: [PATCH] ricoh_mmc: Handle newer models of Ricoh controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081126145039.GA31043@srcf.ucam.org>
Date:	Wed, 26 Nov 2008 14:50:39 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Philip Langdale <philipl@...rt.org>
Cc:	Frans Pop <elendil@...net.nl>, linux-kernel@...r.kernel.org,
	sdhci-devel@...t.drzeus.cx, drzeus@...eus.cx, fseidel@...e.de,
	weyland@...rary.ethz.ch
Subject: Re: [PATCH] ricoh_mmc: Handle newer models of Ricoh controllers

On Wed, Nov 26, 2008 at 06:42:20AM -0800, Philip Langdale wrote:
> Frans Pop wrote:
> >>The latest generation of laptops are shipping with a newer
> >>model of Ricoh chip where the firewire controller is the
> >>primary PCI function but a cardbus controller is also present.
> >
> >Note that the current separate ricoh_mmc disabling module approach has 
> >been shown to break during suspend/resume. Matthew Garret proposed a 
> >patch for that which (with minor fixups) I tested successfully.
> 
> Hmm. Well, I'm interested as to what Pierre thinks. He explicitly didn't
> want a quirk when we originally looked at the problem and that's why
> ricoh_mmc exists - but maybe this is a good enough reason to revisit that
> decision.

Thinking about it, it could possibly be handled by changing to 
suspend_noirq and resume_noirq rather than the normal suspend and resume 
functions? That ought to get the ordering constraints right. The problem 
occurs when ricoh_mmc suspends before sdhci and resumes after it.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/