linux-kernel - Re: [PATCH] [XFS] fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081126162214.GA10251@infradead.org>
Date:	Wed, 26 Nov 2008 11:22:14 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	Christoph Hellwig <hch@...radead.org>,
	David Chinner <david@...morbit.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] [XFS] fix sparse warning

On Wed, Nov 26, 2008 at 04:54:53PM +0100, Hannes Eder wrote:
> Impact: fix sparse warning
> 
> Fix the following sparse warning:
> 
>   fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
> 
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
>  fs/xfs/xfs_inode.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index c6e295e..7a828cb 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
>  static inline void xfs_destroy_inode(struct xfs_inode *ip)
>  {
>  	make_bad_inode(VFS_I(ip));
> -	return destroy_inode(VFS_I(ip));
> +	destroy_inode(VFS_I(ip));
>  }

Yes, this makes sense.  Thanks for the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/