linux-kernel - Re: [PATCH] fakephp: Allocate PCI resources before adding the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081126181841.GF6539@plum>
Date:	Wed, 26 Nov 2008 10:18:41 -0800
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Trent Piepho <xyzzy@...akeasy.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] fakephp: Allocate PCI resources before adding the device

On Wed, Nov 26, 2008 at 01:56:45AM -0800, Trent Piepho wrote:
> Ok, that makes sense.  The device I'm using fakephp for doesn't have a
> kernel driver so I wouldn't have noticed that.
> 
> Have you tested this with a device that isn't present at boot?  I found
> that I needed to a call to pci_enable_device() after assigning resources,
> otherwise the BARs wouldn't be enabled.  This only happened if the device
> wasn't present at boot time.

Yes, I was actually using this driver to <cough> turn the ioatdma
controller on after turning it off in the BIOS.

> My hardware doesn't run on the latest kernel so I can't test it.  It looks
> like there have been a bunch of pci hotplug changes so back porting this
> might not be feasible.  It also looks a previous patch by Alex Chiang
> completely changed the sysfs interface for fakephp.  I thought sysfs
> interfaces were supposed to be stable?!  Also looks like it made fakephp

I doubt that, sysfs interfaces change all the time.  I think only the
syscall interface has any sort of stability guarantee.

> useless.  How are you supposed to figure out which "fake-n" directory is
> the right one to disable the device you want?

cat /sys/bus/pci/slots/fake*/address

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/