linux-kernel - Re: [PATCH 2/2] relatime: Allow making relatime the default behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2008 14:11:40 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	mingo@...hat.com, val.henson@...il.com
Subject: Re: [PATCH 2/2] relatime: Allow making relatime the default behaviour

On Wed, Nov 26, 2008 at 07:58:24PM +0000, Matthew Garrett wrote:
> +#define MS_NORELATIME	(1<<24)	/* Disable relatie even if the default */

typo

Otherwise, looks good.

Reviewed-by: Matthew Wilcox <willy@...ux.intel.com>

Instead of using __setup, could we use core_param() for these two
parameters?  I'm not sure that core_param are exposed in /sys or /proc
anywhere ... if we could fix that, I think it'd simplify this patch
enormously.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/