[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.1.10.0811252201270.26424@gandalf.stny.rr.com>
Date: Tue, 25 Nov 2008 22:03:35 -0500 (EST)
From: Steven Rostedt <rostedt@...dmis.org>
To: Liming Wang <liming.wang@...driver.com>
cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ftrace: adding other non-leaving .text sections
On Wed, 26 Nov 2008, Liming Wang wrote:
> Please review this patch, and I don't know whether new sections will conflict
> with sched tracer or others.
> This patch is against Steven tree's tip/devel latest commit.
>
> Impact: improve recordmcount.pl
>
> Besides .text section, there are three .text sections that won't
> be freed after kernel booting. They are: .sched.text, .spinlock.text
> and .kprobes.text, which contain functions we can trace. But the last
> section ".kprobes.text" is particular, which has been marked as "notrace",
> we ignore it. Thus we add other two sections.
Yep, only those sections that we know will not disappear are OK. I was
conservative with only using ".text" but I knew there were other sections
that were OK, so I used the hash array to make it easy to add others.
Thanks!
Acked-by: Steven Rostedt <srostedt@...hat.com>
-- Steve
>
> Signed-off-by: Liming Wang <liming.wang@...driver.com>
> ---
> scripts/recordmcount.pl | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 0197e2f..0b1dc9f 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -112,6 +112,8 @@ my ($arch, $bits, $objdump, $objcopy, $cc,
> # Acceptable sections to record.
> my %text_sections = (
> ".text" => 1,
> + ".sched.text" => 1,
> + ".spinlock.text" => 1,
> );
>
> $objdump = "objdump" if ((length $objdump) == 0);
> --
> 1.6.0.3
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists