linux-kernel - Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081126030938.GD8242@elte.hu>
Date:	Wed, 26 Nov 2008 04:09:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Muli Ben-Yehuda <muli@...ibm.com>
Cc:	Julia Lawall <julia@...u.dk>, jdmason@...zu.us, discuss@...-64.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change
	simple_strtol to simple_strtoul


* Muli Ben-Yehuda <muli@...ibm.com> wrote:

> On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@...u.dk>
> > 
> > Since bridge is unsigned, it would seem better to use simple_strtoul that
> > simple_strtol.
> > 
> > A simplified version of the semantic patch that makes this change is as
> > follows: (http://www.emn.fr/x-info/coccinelle/)
> > 
> > // <smpl>
> > @r2@
> > long e;
> > position p;
> > @@
> > 
> > e = simple_strtol@p(...)
> > 
> > @@
> > position p != r2.p;
> > type T;
> > T e;
> > @@
> > 
> > e = 
> > - simple_strtol@p
> > + simple_strtoul
> >   (...)
> > // </smpl>
> > 
> > Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> Acked-by: Muli Ben-Yehuda <muli@...ibm.com>
> 
> Ingo, can you please push?

Sure, applied to tip/x86/urgent, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/