linux-kernel - Re: [PATCH 4/5] x86: ret_from_fork

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Nov 2008 11:15:26 +0100
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Cyrill Gorcunov" <gorcunov@...il.com>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org,
	"Cyrill Gorcunov" <gorcunov@...il.com>
Subject: Re: [PATCH 4/5] x86: ret_from_fork - add CFI proc annotation


On Wed, 26 Nov 2008 22:17:03 +0300, gorcunov@...il.com said:
> From: Cyrill Gorcunov <gorcunov@...il.com>
> 
> ret_from_fork is definitly procedure so mark it as that.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> ---
>  arch/x86/kernel/entry_64.S |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index c409f73..a21be86 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -370,6 +370,7 @@ END(save_paranoid)
>   */
>  /* rdi:	prev */
>  ENTRY(ret_from_fork)
> +	CFI_STARTPROC
>  	DEFAULT_FRAME
>  	push kernel_eflags(%rip)
>  	CFI_ADJUST_CFA_OFFSET 8

This is not needed/wanted. DEFAULT_FRAME includes "CFI_STARTPROC simple"
already.

Alexander

> 1.6.0.4.603.gbc9c0
> 
-- 
  Alexander van Heukelum
  heukelum@...tmail.fm

-- 
http://www.fastmail.fm - The professional email service

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/