linux-kernel - [PATCH] mm: reorder struct bio to remove padding on 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1227787397.3120.7.camel@castor.localdomain>
Date:	Thu, 27 Nov 2008 12:03:17 +0000
From:	Richard Kennedy <richard@....demon.co.uk>
To:	neilb@...e.de
Cc:	lkml <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>
Subject: [PATCH] mm: reorder struct bio to remove padding on 64bit

remove 8 bytes of padding from struct bio which also removes 16 bytes
from struct bio_pair to make it 248 bytes. bio_pair then fits into one
fewer cache lines & into a smaller slab.

Signed-off-by: Richard Kennedy <richard@....demon.co.uk>
---
Hi Neil,
This compiles but hasn't had any testing, as I don't have a raid to test
it on. 
patch against 2.6.28-rc6.
regards
Richard



diff --git a/include/linux/bio.h b/include/linux/bio.h
index 6a64209..e6789b2 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -90,10 +90,11 @@ struct bio {
 
 	unsigned int		bi_comp_cpu;	/* completion CPU */
 
+	atomic_t		bi_cnt;		/* pin count */
+
 	struct bio_vec		*bi_io_vec;	/* the actual vec list */
 
 	bio_end_io_t		*bi_end_io;
-	atomic_t		bi_cnt;		/* pin count */
 
 	void			*bi_private;
 #if defined(CONFIG_BLK_DEV_INTEGRITY)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/