[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081127124116.GK6703@one.firstfloor.org>
Date: Thu, 27 Nov 2008 13:41:16 +0100
From: Andi Kleen <andi@...stfloor.org>
To: eranian@...il.com
Cc: Oleg Nesterov <oleg@...hat.com>, Ingo Molnar <mingo@...e.hu>,
linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
x86@...nel.org, andi@...stfloor.org, sfr@...b.auug.org.au,
Roland McGrath <roland@...hat.com>
Subject: Re: [patch 20/24] perfmon: system calls interface
> int pfm_create(int flags, pfarg_sinfo_t *sif, char *fmt_name, void
> *fmt_arg, size_t arg_sz);
>
> The kernel would look at the last 3 arguments ONLY if it saw the
> PFM_FL_SMPL_FMT bit
> set in flags. We follow the model used by open(2).
Normally it's a better model to enforce 0 (or whatever appropiate)
in unused argument. That can be done by checking and returning EINVAL.
>
> I want to double-check that you are fine with this approach.
My recommendation would be to go with the full format
from the beginning, because otherwise there is a versioning problem
with glibc.
-Andi
--
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists