linux-kernel - Re: [patch 05/24] perfmon: X86 generic code (x86)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0811271540190.3325@localhost.localdomain>
Date:	Thu, 27 Nov 2008 15:40:50 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	David Miller <davem@...emloft.net>
cc:	eranian@...il.com, sfr@...b.auug.org.au, andi@...stfloor.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, x86@...nel.org
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)

On Thu, 27 Nov 2008, David Miller wrote:
> From: Thomas Gleixner <tglx@...utronix.de>
> >   __attribute__ ((packed)); ???
> 
> Shouldn't be needed and this woule kill performance on RISC (every
> struct member is accessed with byte sized loads and shifts/masking).
> 
> We did this for the pfkey.h structures by accident, and I truly regret
> it.

Fair enough.

Thanks,

	tglx
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/