linux-kernel - Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530811270658x47f4f950m6c4c71f8674d27f1@mail.gmail.com>
Date:	Thu, 27 Nov 2008 15:58:25 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Steven Rostedt" <rostedt@...dmis.org>,
	"Tim Bird" <tim.bird@...sony.com>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output

2008/11/27 Ingo Molnar <mingo@...e.hu>:
>
> * Frédéric Weisbecker <fweisbec@...il.com> wrote:
>
>> >> >  0)    0.993 us |      }
>> >> > +0)   11.649 us |    }
>> >> >  0)             |    do_sync_read() {
>> >> >  0)             |      sock_aio_read() {
>> >> >  0)             |        __sock_recvmsg() {
>> >> >  0)             |          security_socket_recvmsg() {
>> >> > !0)  100.319 us |            cap_socket_recvmsg();
>> >> > ---------------------------------------------------------
>>
>> I like it before the CPU number. The main purpose would be to scroll
>> quickly the file and find the overheads. That would be easy if set
>> as a first character.
>>
>> I will set it as a default disabled option.
>
> lets keep it default-enabled, ok? It makes sense.

Ok.
BTW I understand why it is better to have a "pipe" if there is no time:

  0)             |    do_sync_read() {
  0)             |      sock_aio_read() {
  0)             |        __sock_recvmsg() {
  0)             |          security_socket_recvmsg() {

But I don't see why it is necessary to have one just after the time:

!0)  100.319 us |            cap_socket_recvmsg();

It appears to me as noise....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/