linux-kernel - Re: [PATCH 1/3] percpu: fix percpu accessors to potentially !cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <swf4p1taw38.wl%takata@linux-m32r.org>
Date:	Fri, 28 Nov 2008 02:59:39 +0900
From:	Hirokazu Takata <takata@...ux-m32r.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Hirokazu Takata <takata@...ux-m32r.org>,
	Mike Travis <travis@....com>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] percpu: fix percpu accessors to potentially !cpu_possible() cpus: m32r

Acked-by: Hirokazu Takata <takata@...ux-m32r.org>

At Fri, 21 Nov 2008 21:09:01 +1030, Rusty Russell wrote:
> 
> Impact: CPU iterator bugfixes
> 
> Percpu areas are only allocated for possible cpus.  In general, you
> shouldn't access random cpu's percpu areas.
> 
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> Signed-off-by: Mike Travis <travis@....com>
> Acked-by: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/m32r/kernel/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- test-compile.orig/arch/m32r/kernel/smpboot.c
> +++ test-compile/arch/m32r/kernel/smpboot.c
> @@ -598,7 +598,7 @@ int setup_profiling_timer(unsigned int m
>  	 * accounting. At that time they also adjust their APIC timers
>  	 * accordingly.
>  	 */
> -	for (i = 0; i < NR_CPUS; ++i)
> +	for_each_possible_cpu(i)
>  		per_cpu(prof_multiplier, i) = multiplier;
>  
>  	return 0;
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/