linux-kernel - Re: [PATCH] markers: comment marker_synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081128154759.GH28138@elte.hu>
Date:	Fri, 28 Nov 2008 16:47:59 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>, Avi Kivity <avi@...hat.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>
Subject: Re: [PATCH] markers: comment marker_synchronize_unregister() on
	data dependency


* Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> * Wu Fengguang (fengguang.wu@...el.com) wrote:
> > On Thu, Nov 27, 2008 at 10:00:03AM +0200, Mathieu Desnoyers wrote:
> > > * Wu Fengguang (fengguang.wu@...el.com) wrote:
> > > > +
> > > > +marker_synchronize_unregister() must be called before the first occurrence of
> > > 
> > > 
> > > You should probably say 
> > > 
> > > ".. must be called between probe unregistration and the first occurence
> > > of..."
> > > 
> > > Mathieu
> > 
> > That's much better!
> > 
> > With your comments I'd assume you reviewed this patch ;-)
> > 
> > Thanks,
> > Fengguang
> > ---
> > markers: comment marker_synchronize_unregister() on data dependency
> > 
> > Add document and comments on marker_synchronize_unregister(): it
> > should be called before freeing resources that the probes depend on.
> > 
> > Based on comments from Lai Jiangshan and Mathieu Desnoyers.
> > 
> > Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
> > Reviewed-by: Lai Jiangshan <laijs@...fujitsu.com>
> > Signed-off-by: Wu Fengguang <wfg@...ux.intel.com>
> 
> It looks good to me, thanks!
> 
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

applied to tip/tracing/markers, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/