linux-kernel - Re: HP WMI laptop extras driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 28 Nov 2008 16:12:49 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Daniel Perzynski <daniel.perzynski@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: HP WMI laptop extras driver

On Sat, Nov 22, 2008 at 10:40:17PM +0100, Daniel Perzynski wrote:

> Nov 22 13:11:49 h3xu5 input: HP WMI hotkeys as /class/input/input9
> quickplay button -> Nov 22 13:13:10 h3xu5 HP WMI: Unknown key pressed - 22142
> quickplay dvd button  -> Nov 22 13:14:22 h3xu5 HP WMI: Unknown key pressed -
> 220e6
> quickplay TV button -> Nov 22 13:14:52 h3xu5 HP WMI: Unknown key pressed -
> 22181

Hm. I /suspect/ that these would be better handled by a quickplay button 
driver. There's a patch for that lying around - I'll try to get it 
updated.

> previous track button -> Nov 22 13:15:50 h3xu5 HP WMI: Unknown key pressed -
> 32192
> stop button -> Nov 22 13:16:15 h3xu5 HP WMI: Unknown key pressed - 32191
> play/pause button -> Nov 22 13:16:30 h3xu5 HP WMI: Unknown key pressed - 32190
> next track  button -> Nov 22 13:16:46 h3xu5 HP WMI: Unknown key pressed - 32193
> 
> 4 above buttons are working fine in x-windows

Ok, so again handling them in hp-wmi is probably not a good idea.

> As I understand wifi on/off is supported already by hp-wmi driver

Yup.

> sound mute button -> Nov 22 13:23:28 h3xu5 HP WMI: Unknown key pressed - 32190
> volume up -> Nov 22 13:24:02 h3xu5 HP WMI: Unknown key pressed - 32190
> volume down -> Nov 22 13:24:04 h3xu5 HP WMI: Unknown key pressed - 32190
> 
> above 3 are working fine in x-windows

Since they're going through the keyboard controller, we should probably 
ignore them.

> bass/treble switch button -> Nov 22 13:25:06 h3xu5 HP WMI: Unknown key pressed
> - 22199
> bass/treble up button:
> Nov 22 13:26:18 h3xu5 HP WMI: Unknown key pressed - 22197
> Nov 22 13:26:18 h3xu5 atkbd.c: Unknown key pressed (translated set 2, code 0xbe
> on isa0060/serio0).
> Nov 22 13:26:18 h3xu5 atkbd.c: Use 'setkeycodes e03e <keycode>' to make it
> known.
> bass/treble down button:
> Nov 22 13:26:21 h3xu5 HP WMI: Unknown key pressed - 22198
> Nov 22 13:26:21 h3xu5 atkbd.c: Unknown key pressed (translated set 2, code 0xbf
> on isa0060/serio0).
> Nov 22 13:26:21 h3xu5 atkbd.c: Use 'setkeycodes e03f <keycode>' to make it
> known.
> cd eject button -> Nov 22 13:26:45 h3xu5 HP WMI: Unknown key pressed - 0

Again, looks like these are going through the keyboard controller. 
Thanks for the feedback, I'll try to work out a way of avoiding printing 
the messages.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/