linux-kernel - Re: [PATCH] vfs, seqfile: make mangle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081128170805.GE10487@elte.hu>
Date:	Fri, 28 Nov 2008 18:08:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	T?r?k Edwin <edwintorok@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Alexander Viro <viro@....linux.org.uk>, srostedt@...hat.com,
	a.p.zijlstra@...llo.nl, sandmann@...mi.au.dk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs, seqfile: make mangle_path() global


* Al Viro <viro@...IV.linux.org.uk> wrote:

> On Sun, Nov 23, 2008 at 09:47:37AM +0100, Ingo Molnar wrote:
> > 
> > * T?r?k Edwin <edwintorok@...il.com> wrote:
> > 
> > >  fs/seq_file.c            |   14 +++++++-
> > >  include/linux/seq_file.h |    1 +
> > 
> > Note, i've split these bits out into a separate patch - see it 
> > attached below.
> 
> ACK, [...]

thanks!

> [...] except that I wouldn't use _GPL in the export - it's trivial to 
> reproduce, so we are not protecting anything here.  And all that code 
> has been moved verbatim from seq_path(), which is mine *and* exported 
> without _GPL nonsense.
> 
> As far as I'm concerned, all these helpers are as general-purpose as 
> atoi() et.al. - library functions damn close to being non-copyrightable 
> due both to triviality and to being absolutely straightforward 
> implementations - tell anybody to implement it and that's what you'll 
> get.
> 
> I'm not fond of proprietary modules, to put it mildly, but let's not 
> get completely ridiculous.  In this case it's as dumb as schools trying 
> to ban aspirin in the name of War On Some Drugs.

okay, fair enough. Would the commit below be fine with you?

Also, since we depend on this commit, would it be fine with you if we 
carried the trivial patch in tip/tracing/*?

	Ingo

---------------->
>From 604094f4615180f71da799e7e5b191f5c2a42a28 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Fri, 28 Nov 2008 18:03:22 +0100
Subject: [PATCH] vfs, seqfile: export mangle_path() generally

mangle_path() is trivial enough to make  export restrictions on it
pointless - so change the export from EXPORT_SYMBOL_GPL to EXPORT_SYMBOL.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
Acked-by: Al Viro <viro@...IV.linux.org.uk>
---
 fs/seq_file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/seq_file.c b/fs/seq_file.c
index f03220d..16c2115 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -387,7 +387,7 @@ char *mangle_path(char *s, char *p, char *esc)
 	}
 	return NULL;
 }
-EXPORT_SYMBOL_GPL(mangle_path);
+EXPORT_SYMBOL(mangle_path);
 
 /*
  * return the absolute path of 'dentry' residing in mount 'mnt'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/