linux-kernel - Re: [PATCH] fakephp: Allocate PCI resources before adding the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081128213041.GW25548@parisc-linux.org>
Date:	Fri, 28 Nov 2008 14:30:41 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Trent Piepho <xyzzy@...akeasy.org>
Cc:	Alex Chiang <achiang@...com>,
	"Darrick J. Wong" <djwong@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] fakephp: Allocate PCI resources before adding the	device

On Fri, Nov 28, 2008 at 01:21:22PM -0800, Trent Piepho wrote:
> Sometimes I just want to give up on Linux.  Is there a different interface
> that isn't wantonly changed without warning?  No?  Do you not see the
> problem this creates for developers?  Do you not care?

You see, we didn't know that anyone was using fakephp for real work.
It's marketed as being a way for developers to test their device drivers
with hotplug slots even if they don't have a real hotplug machine.
If we'd known, we'd've done a better job.

BTW, cut the crap about "Sometimes I just want to give up on Linux".
We're putting in a lot of work that you get to use for free.  That doesn't
give you the right to be abusive.  And if you stopped using Linux, we'd
have one fewer person complaining, so I don't personally find it a huge
motivator to drop everything and attend to your whims.

> > What we have now is the 'address' file managed by the core.  This
> > doesn't include the function number.
> 
> So the race condition doesn't matter?  Alex Chiang wasn't even aware
> fakephp could be used to add new devices, so this change obviously wasn't
> though out very well.

There is no race condition.  You can't remove a fakephp slot.

> > There are lots of circumstances where enabling and disabling individual
> > functions is a good idea, but I don't think that fakephp is the right
> > way to do it.  We need a better interface.
> 
> So maybe this better interface should be created before breaking the
> existing one?

Hey, I have a great idea.  Why don't you help instead of just bitching?

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/