linux-kernel - Re: [PATCH -v3 8/8] dnotify: reimplement dnotify using fsnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1227915884.3393.23.camel@localhost.localdomain>
Date:	Fri, 28 Nov 2008 18:44:44 -0500
From:	Eric Paris <eparis@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, malware-list@...ts.printk.net,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	arjan@...radead.org, hch@...radead.org, a.p.zijlstra@...llo.nl
Subject: Re: [PATCH -v3 8/8] dnotify: reimplement dnotify using fsnotify

On Fri, 2008-11-28 at 06:25 +0000, Al Viro wrote:
> On Tue, Nov 25, 2008 at 12:21:33PM -0500, Eric Paris wrote:
> > -	inode->i_dnotify_mask |= arg & ~DN_MULTISHOT;
> > -	dn->dn_next = inode->i_dnotify;
> > -	inode->i_dnotify = dn;
> > -	spin_unlock(&inode->i_lock);
> > -
> > -	if (filp->f_op && filp->f_op->dir_notify)
> > -		return filp->f_op->dir_notify(filp, arg);
> > +	dn->dn_next = entry->private;
> > +	entry->private = dn;
> > +	dnotify_recalc_inode_mask(entry);
> > +	spin_unlock(&inode->i_fsnotify_lock);
> > +	fsnotify_mark_put(entry);
> > +	fsnotify_put_group(dnotify_group);
> 
> Now, that is interesting - you've just taken out the fscked-in-head
> ->dir_notify().  The action is quite laudable, but it deserves being
> announced properly:
> 
> * Remove the hopelessly misguided ->dir_notify().  The only instance (cifs)
> has been broken by design from the very beginning; the objects it creates
> are never destroyed, keep references to struct file they can outlive, nothing
> that could possibly evict them exists on close(2) path *and* no locking
> whatsoever is done to prevent races with close(), should the previous, er,
> deficiencies someday be dealt with.
> 
> While we are at it, removing the only call of that method is obviously
> only a half of the job...

crap, I actually meant to move that out to the actual do_fcntl() call to
get it out of my way.  I did see that it is useless since we don't
handle responses in any way and obviously this has nothing to do with
dnotify.....

I'll poke the cifs people to see if they are ok with dropping it
altogether properly....

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/