linux-kernel - Re: [PATCH] usb/serial: Add compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1227920556.4277.128.camel@aiko.keithp.com>
Date:	Fri, 28 Nov 2008 17:02:36 -0800
From:	Keith Packard <keithp@...thp.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	keithp@...thp.com, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] usb/serial: Add compat_ioctl pass-through

On Fri, 2008-11-28 at 22:33 +0000, Alan Cox wrote:

> Can never be used only overwritten so why not replace with -ENOIOCTLCMD
> and remove the else of the if

Yeah, of course.

> Also I get a CodingStyle whine about the port->serial-> side of the if
> not needing { }

Oops. Changed when I removed the bkl calls.

> No... the ioctl path for tty comes from unlocked_ioctl so the BKL is not
> held and should not be held.

Oh yes, it is -- serial_ioctl does:

        if (port->serial->type->ioctl) {
                lock_kernel();
                retval = port->serial->type->ioctl(tty, file, cmd, arg);
                unlock_kernel();
        } else

I added the comment to make the difference in calling convention
documented in the header file at least, I didn't change the code.

-- 
keith.packard@...el.com

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)