linux-kernel - Re: [PATCH] tracing/function-graph-tracer: adjustments of the trace informations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081129141945.GA10639@elte.hu>
Date:	Sat, 29 Nov 2008 15:19:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frédéric Weisbecker <fweisbec@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Tim Bird <tim.bird@...sony.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/function-graph-tracer: adjustments of the
	trace informations


* Frédéric Weisbecker <fweisbec@...il.com> wrote:

> > Another thing that would be nice is to separate out the "cpu)" 
> > printing bits into a helper function. Right now what exists cannot be 
> > used in a seq-manner, so i couldnt reuse it.
> >
> 
> Isn't it the case with print_graph_cpu() ?

yeah, that should be okay. I didnt use it in verif_pid() because it 
returns print_line_t - but i guess it would be better to fix verif_pid() 
to check for !ret instead of the ret += thing i added.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/