[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081129122039.GA31635@balbir.in.ibm.com>
Date: Sat, 29 Nov 2008 17:50:39 +0530
From: Balbir Singh <balbir@...ux.vnet.ibm.com>
To: Pekka Enberg <penberg@...helsinki.fi>
Cc: jdike@...toit.com, linux-kernel@...r.kernel.org,
user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [PATCH][UML] Boot broken due to buffer overrun
* Pekka Enberg <penberg@...helsinki.fi> [2008-11-29 12:21:46]:
> Hi Balbir,
>
> On Sat, Nov 29, 2008 at 12:08 PM, Balbir Singh
> <balbir@...ux.vnet.ibm.com> wrote:
> > mconsole_init() passed 256 bytes as length in os_create_unix_socket, while
> > the sizeof UNIX_PATH_MAX is 108. This patch fixes that problem and avoids
> > a big overrun bug reported on UML bootup.
>
> Maybe mention that ->sun_path in struct sockaddr_un is UNIX_PATH_MAX
> long which causes the problem?
>
Yes, the changelog can definitely add that to the changelog, I'll
resend the patch if Jeff asks for it.
> > Reported-by: Vikas K Managutte <vikki.km@...il.com>
> > Reported-by: Sarvesh Kumar Lal Das <skldas@...il.com>
> > Signed-off-by: Balbir Singh <balbir@...ux.vnet.ibm.com>
>
> Reviewed-by: Pekka Enberg <penberg@...helsinki.fi>
Thanks!
--
Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists