linux-kernel - Re: [PATCH] usb/serial: Add compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081128172300.0e30229e@infradead.org>
Date:	Fri, 28 Nov 2008 17:23:00 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Keith Packard <keithp@...thp.com>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] usb/serial: Add compat_ioctl pass-through

On Sat, 29 Nov 2008 01:10:57 +0000
Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > Oh yes, it is -- serial_ioctl does:
> > 
> >         if (port->serial->type->ioctl) {
> >                 lock_kernel();
> >                 retval = port->serial->type->ioctl(tty, file, cmd,
> > arg); unlock_kernel();
> >         } else
> > 
> > I added the comment to make the difference in calling convention
> > documented in the header file at least, I didn't change the code.
> 
> Gak I thought I'd killed all of those.
> 
> Let me rephase it "It won't be next week" ;)

it's a double BKL since it's also using .ioctl not .unlocked_ioctl
(but then again we should just over time merge the two into a .ioctl
which is unlocked ;-)


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/