linux-kernel - Re: [PATCH] tracing/branch-tracer: include missing irqflags.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081129091647.GA25109@elte.hu>
Date:	Sat, 29 Nov 2008 10:16:47 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/branch-tracer: include missing irqflags.h


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> Impact: fix build error on branch tracer
> 
> This should fix a build error reported on alpha in linux-next:
> 
>  CC      kernel/trace/trace_branch.o
> kernel/trace/trace_branch.c: In function 'probe_likely_condition':
> kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
> kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'

applied to tip/tracing

> Unfortunately, I can't test it since I don't have any Alpha build 
> environment.

it does not trigger with an Alpha defconfig - we do test that.

And the thing is, lockdep (which introduced irqflags tracing) has been 
introduced upstream two years ago - and Alpha still does not have it 
implemented. The architecture should be marked CONFIG_BROKEN if it 
continues to cause problems like this.

Alexey, you seem to be using and relying on the Alpha architecture, could 
you please have a shot at this and implement the missing irqflags 
infrastructure? Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/