linux-kernel - Re: [PATCH v2] v4l2_device/v4l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200811291856.51900.david-b@pacbell.net>
Date:	Sat, 29 Nov 2008 18:56:51 -0800
From:	David Brownell <david-b@...bell.net>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	Linux and Kernel Video <video4linux-list@...hat.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	linux-kernel@...r.kernel.org,
	Laurent Pinchart <laurent.pinchart@...net.be>
Subject: Re: [PATCH v2] v4l2_device/v4l2_subdev: final (?) version

On Saturday 29 November 2008, Hans Verkuil wrote:
> > > Are there some documented guidelines on when to use BUG_ON?
> >
> > Maybe there should be.  I know I've seen flames from Linus on
> > the topic.  Basically, treat it like a panic() where the system
> > must stop operation lest it catch fire or scribble all over the
> > (not-backed-up) disk ... if the system can keep running sanely,
> > then BUG() and friends are inappropriate.
> 
> I think it would be good to have some document about this, since
> from what I've seen from a quick scan I'm not the only one who uses
> it incorrectly. There is no documentation in the asm-generic/bug.h
> header and there is also no documentation on this in the Documentation
> directory.

Fair enough ... but the basic advice is still going to be "strongly
avoid ever calling BUG()".  

I'll send a patch along doing that.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/