linux-kernel - Re: [PATCH] ATM: horizon, fix hrz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081129.204341.88799313.davem@davemloft.net>
Date:	Sat, 29 Nov 2008 20:43:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jirislaby@...il.com
Cc:	chas@....nrl.navy.mil, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ATM: horizon, fix hrz_probe fail path

From: Jiri Slaby <jirislaby@...il.com>
Date: Sat, 29 Nov 2008 22:34:25 +0100

> One fail path in hrz_probe omitted device disable. Fix it.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>

Applied, but please post all networking patches to
netdev@...r.kernel.org, in particular so that they
get properly tracked at:

	http://patchwork.ozlabs.org/project/netdev/list/

I feel like I type this in at least 10 times a day, so
people please start making sure netdev is on the CC: for
all networking patches.

Thanks!

> ---
>  drivers/atm/horizon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> index 6154123..6b969f8 100644
> --- a/drivers/atm/horizon.c
> +++ b/drivers/atm/horizon.c
> @@ -2705,7 +2705,7 @@ static int __devinit hrz_probe(struct pci_dev *pci_dev, const struct pci_device_
>  
>  	/* XXX DEV_LABEL is a guess */
>  	if (!request_region(iobase, HRZ_IO_EXTENT, DEV_LABEL)) {
> -		return -EINVAL;
> +		err = -EINVAL;
>  		goto out_disable;
>  	}
>  
> -- 
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/