[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <alpine.LFD.2.00.0811292351580.3239@localhost.localdomain>
Date: Sun, 30 Nov 2008 00:03:19 -0500 (EST)
From: Len Brown <lenb@...nel.org>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: Robert Hancock <hancockr@...w.ca>,
Henrique de Moraes Holschuh <hmh@....eng.br>,
Maciej Rutecki <maciej.rutecki@...il.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-acpi@...r.kernel.org, fabio.comolli@...il.com
Subject: Re: [Re: Linux 2.6.28-rc1] ACPI Warning (nspredef-0852)[...]
> The underlying issue is we've never reported such BIOS bugs before and now we
> do that unconditionally. IMnshO, this should only be done if ACPI debugging is
> enabled.
>
> While I can see a value in doing that always, IMO such a change should only be
> made after a big announcement.
I agree that we were aggressive in shipping this checking in 2.6.28-rc.
The checking has no functional effect, except to issue a console warning,
so I figured it had limited down-side.
It actually paid off almost immediately by pointing out why
a Linux bug was provoked on jejb's test box.
I had figured on making it CONFIG_ACPI_DEBUG for the
final release, but at this point we've seen only the
_BIF and _WAK warnings -- and they're both dealt with
via the patches queued for Linus.
So at this point, I'm inclined to keep this checking enabled in
2.6.28-final, independent of CONFIG_ACPI_DEBUG.
-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists