linux-kernel - Re: [PATCH] Fujitsu Amilo PA 1510 key-release events quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081129233826.be959cae.akpm@linux-foundation.org>
Date:	Sat, 29 Nov 2008 23:38:26 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Daniel Mierswa <impulze@...ulze.org>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] Fujitsu Amilo PA 1510 key-release events quirk

On Sat, 29 Nov 2008 22:59:36 +0100 Daniel Mierswa <impulze@...ulze.org> wrote:

> heya,
> the fujitsu amilo pa 1510 laptop needs a little lovin' regarding the 
> release event of the volume up and down keys. I attached a format-patch 
> (against torvalds/linux-2.6.git ed313489badef16d7) which separates the 
> generation of release events for certain scancodes into a macro since 3 
> dmi matches are already using it and generation of the missing release 
> events for that particular laptop. Please post back with any advice and 
> thoughts for that patch.
> 

Please don't send more than one patch per email.  I shall comment on
the two patches in two separate replies.

> From a197dfb0eed23b87418c0a7fe6a562910046576e Mon Sep 17 00:00:00 2001
> From: Daniel Mierswa <impulze@...ulze.org>
> Date: Sat, 29 Nov 2008 22:39:34 +0100
> Subject: [PATCH] Separate macro for generation of keyrelease events
> 
> ---
>  drivers/input/keyboard/atkbd.c |   23 +++++++++++++----------
>  1 files changed, 13 insertions(+), 10 deletions(-)

Please also cc linux-input@...r.kernel.org on input-related patches.

> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 22016ca..99ef522 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -834,6 +834,17 @@ static void atkbd_disconnect(struct serio *serio)
>  }
>  
>  /*
> + * generate release events for the keycodes given in forced_release_keys[]
> + */
> +#define GEN_RELEASE_EVENT \
> +	int i; \
> +\
> +	if (atkbd->set == 2) \
> +		for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++) \
> +			__set_bit(forced_release_keys[i], \
> +				atkbd->force_release_mask);
> +
> +/*
>   * Most special keys (Fn+F?) on Dell laptops do not generate release
>   * events so we have to do it ourselves.
>   */
> @@ -842,12 +853,8 @@ static void atkbd_dell_laptop_keymap_fixup(struct atkbd *atkbd)
>  	const unsigned int forced_release_keys[] = {
>  		0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93,
>  	};
> -	int i;
>  
> -	if (atkbd->set == 2)
> -		for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
> -			__set_bit(forced_release_keys[i],
> -				  atkbd->force_release_mask);
> +	GEN_RELEASE_EVENT
>  }
>  
>  /*
> @@ -859,12 +866,8 @@ static void atkbd_hp_keymap_fixup(struct atkbd *atkbd)
>  	const unsigned int forced_release_keys[] = {
>  		0x94,
>  	};
> -	int i;
>  
> -	if (atkbd->set == 2)
> -		for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
> -			__set_bit(forced_release_keys[i],
> -					atkbd->force_release_mask);
> +	GEN_RELEASE_EVENT
>  }

oh my.  Please, no.  Just write a C function:

void atkbd_gen_release_event(unsigned int *keys, unsigned nr_keys)
{
	...
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/