linux-kernel - Re: powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081130111614.21b194c5@lxorguk.ukuu.org.uk>
Date:	Sun, 30 Nov 2008 11:16:14 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	roel kluin <roel.kluin@...il.com>, benh@...nel.crashing.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: powerpc: hv{cs, si}_close() both unsigned hp->count and
 hvcsd->open_count cannot be negative

> Also, I don't see why those changes have anything to do with "unsigned
> things cannot be negative".  As long as those counts are never zero on
> entry to those code sections, the existing code is fine, and I believe
> that assertion can be maintained.  If you believe the code needs to
> defend against the possibility of a zero count on entry, that should
> have been explicitly stated in the patch description.

See the tty_port patches in -next - this is an argument about code which
ought eventually to go away replaced by standard helper functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/